git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 17:03 UTC

Re: [PATCH v2 0/3] refs/reftable: fix on-disk representation of reflog timezones

From
Karthik Nayak <karthik.188@gmail.com>
Date
Oct 1, 2026, 10:19 UTC
Message-ID
<CAOLa=ZRVt=e3MqjLY=UkitfSg_YjpsfFjeDsEmqJQm-5YhopxA@mail.gmail.com>
In-Reply-To
<20261001-pks-reftables-fix-timezone-format-v2-0-a4fd1f7cd21a@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 23 quoted lines
> Hi,
>
> it was reported [1] that the way we store reflog timezones with the
> reftable format has a mismatch with the reftable specification. While
> the spec says that reftables should be stored as a signed offset in
> minutes, we store them in the "[+-]HHMM" format that we typically use in
> commit headers, for example.
>
> This patch series fixes this bug by making our on-disk representation
> match the specification. This will of course make us reinterpret old
> reftables. But ultimately, the fallout caused by this change is somewhat
> limited as we only ever use reflog timezones for display purposes. So
> yes, we'll display a wrong timezone. But it's not used as part of any
> kind of computations.
>
> The series is built on top of v2.56.0.
>
> Changes in v2:
>   - Improve readability of one of the converted sites that now use
>     `minutes_to_tz()`.
>   - Improve test coverage.
>   - Link to v1: https://patch.msgid.link/20260929-pks-reftables-fix-timezone-format-v1-0-3df105a95ed1@pks.im
>
The range-diff looks in order. This version looks good to me!
[snip]
Previous: Karthik NayakNext: Junio C Hamano
Message 15 of 16 in “refs/reftable: fix on-disk representation of reflog timezones”
  1. 0/3 refs/reftable: fix on-disk representation of reflog timezonesPatrick Steinhardt, Sep 29, 2026
  2. 1/3 date: add helpers to convert between "+HHMM" timezones and minutesPatrick Steinhardt, Sep 29, 2026
  3. 2/3 t/helper: fix segfault in "dump-reftable -t"Patrick Steinhardt, Sep 29, 2026
  4. 3/3 refs/reftable: fix on-disk representation of reflog timezonesPatrick Steinhardt, Sep 29, 2026
  5. Karthik NayakSep 30, 2026
  6. Karthik NayakSep 30, 2026
  7. Patrick SteinhardtSep 30, 2026
  8. Patrick SteinhardtSep 30, 2026
  9. Junio C HamanoSep 30, 2026
  10. 0/3 refs/reftable: fix on-disk representation of reflog timezonesPatrick Steinhardt, Oct 1, 2026
  11. 1/3 date: add helpers to convert between "+HHMM" timezones and minutesPatrick Steinhardt, Oct 1, 2026
  12. 2/3 t/helper: fix segfault in "dump-reftable -t"Patrick Steinhardt, Oct 1, 2026
  13. 3/3 refs/reftable: fix on-disk representation of reflog timezonesPatrick Steinhardt, Oct 1, 2026
  14. Karthik NayakOct 1, 2026
  15. Karthik NayakOct 1, 2026
  16. Junio C HamanoOct 1, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.