Re: [PATCH v2 4/4] makefile/meson: add 'headers-check' as alias for 'hdr-check'
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Apr 14, 2025, 14:27 UTC
- Message-ID
- <CAOLa=ZQNrqf+cqatpbW7jeX6e7XAmk7NZZBH1inYMCjFj23C-Q@mail.gmail.com>
- In-Reply-To
- <xmqqtt6voncw.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 18 quoted lines
> Phillip Wood <phillip.wood123@gmail.com> writes: > >> On 10/04/2025 12:30, Karthik Nayak wrote: >>> The 'hdr-check' target in meson and makefile is used to check if headers >>> can be compiled individually. The naming however isn't readable as 'hdr' >>> is not a common shortforme for 'header', neither is it an abbreviation. >>> Let's introduce 'headers-check' as an alternative target for >>> 'hdr-check' >>> and add a `TODO` to deprecate the latter after 2 releases. Since this >>> is an internal tool, we can use a shorter deprecation cycle. >> >> Can we call this "check-headers" to match the other "check-" targets >> in the Makefile please > > Excellent suggestion. If we were to change things, we should get it > right just once. > > Thanks.
Yeah I agree too, I based it off 'coccicheck', but seems like 'check-*' is more consistent.
Thanks