Re: [PATCH v4 0/5] meson: add corresponding target for Makefile's hdr-check

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Apr 23, 2025, 10:04 UTC
Message-ID: <1996b081-2684-49e0-a99d-28f22063b4b6@gmail.com>
In-Reply-To: <xmqqplh55ju3.fsf@gitster.g>

On 21/04/2025 21:40, Junio C Hamano wrote:

Show 5 quoted lines

> Phillip Wood <phillip.wood123@gmail.com> writes:
> 
> Yuck.  I somehow thought that CI jobs are always using a git
> checkout, not tarball extract (after all, that is what
> actions/checkout implies to me X-<).

That's what I'd assumed as well, I was quite surprised when I realized the "checkout" action was actually unpacking a tarball

Best Wishes

Phillip

Show 13 quoted lines

> Of course it is good to
> automatically ensure that our tarball extracts are buildable, but
> the way tarballs are built upon release is probably different from
> how these tarballs are made automatically (*), so in that sense not
> building from a repository but building from "git archive" extract
> is not doing anybody a service.
> 
> 
> [Footnote]
> 
>   * "make dist" is how a release tarball is built for this project,
>     not "git archive dist.tar HEAD".
>