Re: [PATCH 00/19] [GSOC] cat-file: reuse ref-filter logic

>
> On Mon, Jul 12, 2021 at 1:47 PM ZheNing Hu via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> >
> > This patch series make cat-file reuse ref-filter logic.
>
> s/make/makes/
>
> By the way if you have already sent some of the patches in this series
> (and if they haven't changed much since when you sent them), it's a
> good idea to use V2 or V3, V4, etc, so we can easily refer to each of
> the versions you sent. (See the `-v` option of `git format-patch`.)
>

> > Change from last version:
> >
> >  1. Declare buf_size in if (atom_type == ATOM_RAW) block.
> >  2. Modify the code style of the test.
> >  3. Delete "use_textconv" and "use_filter" flag. Instead, add member
>
> s/flag/flags/
>
> >     cat_file_cmdmode to struct ref_array_item.
> >  4. Add function reject_atom() to enhance the readability of the code.
> >  5. Create p1006-cat-file.sh for performance regression testing.
> >  6. Use a "fast path" to output object data to reduce the performance
> >     degradation of cat-file --batch with the suggest of Ævar Arnfjörð
> >     Bjarmason.
>
> Maybe:
>
> s/with the suggest of Ævar Arnfjörð Bjarmason/as suggested by Ævar
> Arnfjörð Bjarmason/
>
> or:
>
> s/with the suggest of Ævar Arnfjörð Bjarmason/according to Ævar
> Arnfjörð Bjarmason's suggestion/
>
>
> > ZheNing Hu (19):
> >   cat-file: handle trivial --batch format with --batch-all-objects
> >   cat-file: merge two block into one
>
> It's a bit strange that the above 2 don't have [GSOC] while the others
> below have it.
>

> >   [GSOC] ref-filter: add obj-type check in grab contents
> >   [GSOC] ref-filter: add %(raw) atom
> >   [GSOC] ref-filter: --format=%(raw) re-support --perl
> >   [GSOC] ref-filter: use non-const ref_format in *_atom_parser()
> >   [GSOC] ref-filter: add %(rest) atom
> >   [GSOC] ref-filter: pass get_object() return value to their callers
> >   [GSOC] ref-filter: introduce free_ref_array_item_value() function
> >   [GSOC] ref-filter: introduce reject_atom()
> >   [GSOC] ref-filter: modify the error message and value in get_object
> >   [GSOC] cat-file: add has_object_file() check
> >   [GSOC] cat-file: change batch_objects parameter name
> >   [GSOC] cat-file: reuse ref-filter logic
> >   [GSOC] cat-file: reuse err buf in batch_object_write()
> >   [GSOC] cat-file: re-implement --textconv, --filters options
> >   [GSOC] ref-filter: remove grab_oid() function
> >   [GSOC] cat-file: create p1006-cat-file.sh
>
> Maybe you could add the new perf test earlier in the series so that we
> could see how performance changes when ref-filter logic is reused in
> cat-file earlier in the series.