Re: [PATCH 14/19] [GSOC] cat-file: reuse ref-filter logic

From: ZheNing Hu <adlternative@gmail.com>
Date: Jul 12, 2021, 13:51 UTC
Message-ID: <CAOLTT8QzBQOJahy2_MX_ShwErfxgwfGByfsjdZBy2C=qStCswA@mail.gmail.com>
In-Reply-To: <CAP8UFD1NfCXDVwaVWKvTWofFHbLee=JRzr4sQBecMMaqi0eWBw@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> 于2021年7月12日周一 下午9:26写道：

Show 11 quoted lines

>
> >
> > I wonder if the above function and some of the tests below could be
> > introduced in a preparatory patch before this one. It could help check
> > that reusing ref-filter doesn't change the behavior with some atoms
> > that were previously supported or rejected. Of course if some atoms
> > are now failing or are now supported, then it's ok to add new tests
> > for these atoms in this patch.
>
> For example maybe some of the tests could be introduced earlier when
> the reject_atom() function is introduced.

Yeah, move it to "[GSOC] ref-filter: add %(rest) atom"  is better.

Thanks. -- ZheNing Hu