Re: [PATCH 0/6] [GSOC][RFC] ref-filter: add %(raw:textconv) and %(raw:filters)

From: ZheNing Hu <adlternative@gmail.com>
Date: Jun 7, 2021, 13:06 UTC
Message-ID: <CAOLTT8SXj0bo2iqr4OAHHaSDCVbjAogAEvgFjupJBS-2N6dxHQ@mail.gmail.com>
In-Reply-To: <xmqq35tuw74h.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> 于2021年6月7日周一 下午1:56写道：

Show 11 quoted lines

>
> "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > The current series is based on 0efed9435 ([GSOC] ref-filter: add %(raw)
> > atom)
>
> I do not have that commit object, but these six patches include the
> two commits that are %(raw) and %(raw:size), so I'll just discard
> the old round that wasn't based on the atom-type stuff and queue
> these six as a single series.
>

Well, it is a commit that has not been sent to the mailing list. But it’s okay to treat the new 6 commits as a new patch series.

Show 6 quoted lines

> As I already said, I am not sure how %(rest) makes any sense outside
> the context of "cat-file --batch"; I suspect it would make more sense
> to make it easier to arrange certain placeholders to error out when
> used in a context where they do not make sense (e.g. use of --rest
> in "git branch --list").
>

I agree.

-- ZheNing Hu