Re: Accept-language test fails on Mac OS

From: Michael Blume <blume.mike@gmail.com>
Date: Dec 5, 2014, 23:01 UTC
Message-ID: <CAO2U3QikrHRC0PncO2vxFMv88HMnJHYa1AiPak+Lp0OU1u6dZA@mail.gmail.com>
In-Reply-To: <xmqqppbxogli.fsf@gitster.dls.corp.google.com>

On Fri, Dec 5, 2014 at 2:51 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Michael Blume <blume.mike@gmail.com> writes:
>
>> Test #25 'git client sends Accept-Language based on LANGUAGE, LC_ALL,
>> LC_MESSAGES and LANG' in t5550 fails consistently on my mac, and has
>> since the test was introduced. Test 26 and 27 ('git client sends
>> Accept-Language with many preferred languages' and 'git client does
>> not send Accept-Language') seem fine.
>>
>> I'm building git with NO_GETTEXT=1, which may be an issue? But in that
>> case the test should probably be gated on gettext?
>
> I recall queuing a SQUASH??? on top of the posted patch; does these
> tests pass with it reverted?

The test fails both on pu and on 7567fad which is prior to the SQUASH??? commit, so the squash does not seem to change anything.