Re: Accept-language test fails on Mac OS
- From
Yi, EungJun <semtlenori@gmail.com>
- Date
- Dec 7, 2014, 06:54 UTC
- Message-ID
- <CAFT+Tg_OQLj7oWfOJ8ATKHo36Jv3+JcSYWEc-trKsAtjv7wskg@mail.gmail.com>
- In-Reply-To
- <54836F46.9080009@web.de>
Thank you for providing useful information to fix the failures.
On Sun, Dec 7, 2014 at 6:04 AM, Torsten Bögershausen <tboegi@web.de> wrote:
Show 14 quoted lines
> On 2014-12-06 20.44, Yi, EungJun wrote: >> Could you tell me your locale information from executing 'locale' >> command and the verbose message you can get by accessing any git >> repository via HTTP protocol? (e.g. GIT_CURL_VERBOSE=1 git clone >> http://github.com/foo/bar ) > locale -a > C > C.UTF-8 > en_US.utf8 > icelandic > is_IS > is_IS.iso88591 > is_IS.utf8 > POSIX
I'm sorry for bothering you, but could you tell me the result of "locale" command without "-a" option? What I want to know is locale environment variables and its values, so I want to reproduce the test failures on my laptop.
Show 40 quoted lines
>
> -----------------------------
> After patching like this:
> diff --git a/t/t5550-http-fetch-dumb.sh b/t/t5550-http-fetch-dumb.sh
> index fc6e7fc..1e42b42 100755
> --- a/t/t5550-http-fetch-dumb.sh
> +++ b/t/t5550-http-fetch-dumb.sh
> @@ -205,8 +205,8 @@ check_language () {
> LANG=$5 \
> git ls-remote "$HTTPD_URL/dumb/repo.git" 2>&1 |
> tr -d '\015' |
> - sort -u >stderr &&
> - grep -i ^Accept-Language: stderr >actual &&
> + sort -u >stderr
> + grep -i ^Accept-Language: stderr >actual
> test_cmp expect actual
> }
> -----------
> I get this:
>
>
> expecting success:
> check_language "ko-KR, *;q=0.1" ko_KR.UTF-8 de_DE.UTF-8 ja_JP.UTF-8 en_US.UTF-8 &&
> check_language "de-DE, *;q=0.1" "" de_DE.UTF-8 ja_JP.UTF-8 en_US.UTF-8 &&
> check_language "ja-JP, *;q=0.1" "" "" ja_JP.UTF-8 en_US.UTF-8 &&
> check_language "en-US, *;q=0.1" "" "" "" en_US.UTF-8
>
> --- expect 2014-12-06 21:00:59.000000000 +0000
> +++ actual 2014-12-06 21:00:59.000000000 +0000
> @@ -1 +0,0 @@
> -Accept-Language: de-DE, *;q=0.1
> not ok 25 - git client sends Accept-Language based on LANGUAGE, LC_ALL, LC_MESSAGES and LANG
> #
> # check_language "ko-KR, *;q=0.1" ko_KR.UTF-8 de_DE.UTF-8 ja_JP.UTF-8 en_US.UTF-8 &&
> # check_language "de-DE, *;q=0.1" "" de_DE.UTF-8 ja_JP.UTF-8 en_US.UTF-8 &&
> # check_language "ja-JP, *;q=0.1" "" "" ja_JP.UTF-8 en_US.UTF-8 &&
> # check_language "en-US, *;q=0.1" "" "" "" en_US.UTF-8
> #
>
>The test seems to fail if LANGUAGE="". I will dig it. Thanks.