git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] ci: new github-action for git-l10n code review

From
Jiang Xin <worldhello.net@gmail.com>
Date
Aug 24, 2021, 13:36 UTC
Message-ID
<CANYiYbHUB-1LTyqCU2eFdYB7rHYq8v-ZBtL7ZR2wERfZry8TqQ@mail.gmail.com>
In-Reply-To
<xmqqsfyzq1wq.fsf@gitster.g>
On Tue, Aug 24, 2021 at 5:36 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 36 quoted lines
>
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >> For a push event, it will scan commits one by one. If a commit does not
> >> look like a l10n commit (no file in "po/" has been changed), it will
> >> immediately fail without checking for further commits. While for a
> >> pull_request event, all new introduced commits will be scanned.
> >>
> >> "git-po-helper" will generate two kinds of suggestions, errors and
> >> warnings. A l10n contributor should try to fix all the errors, and
> >> should pay attention to the warnings. All the errors and warnings will
> >> be reported in the last step of the l10n workflow as two message groups.
> >> For a pull_request event, will create additional comments in pull
> >> request to report the result.
> >
> > It is a good idea to automate this.
> >
> > I am a bit concerned that the `ci-config` approach, even if we use it in
> > the Git project itself, is quite cumbersome to use, though. So I hope that
> > we can find an alternative solution.
> >
> > One such solution could be to make the `git-po-helper` job contingent on
> > part of the repository name. For example:
> >
> >   git-po-helper:
> >     if: endsWith(github.repository, '/git-po')
> >     [...]
> >
> > would skip the job unless the target repository's name is `git-po`.
>
> Nice.
>
> Can this be made into a matter purely local to git-l10n/git-po
> repository and not git/git repository?  I am wondering if we can ee
> if the current repository is git-l10n/git-po or its fork and run it
> only if that is true.

I have read almost all the github documents on github actions, and tried to find if I can use a local branch, such as "github-action" to hold local github-actions, but no locky.

That is to say, the workflow file must be introduced to the master branch of “git-l10n/git-po”. As "git-l10n/git-po" is a fork of "git/git", the new workflow should be part of "git/git", and provide a way to disable it by default.

-- Jiang Xin

Previous: Jiang XinNext: Junio C Hamano
Message 11 of 24 in “ci: new github-action for git-l10n code review”
  1. 0/1 ci: new github-action for git-l10n code reviewJiang Xin, Aug 22, 2021
  2. 1/1 ci: new github-action for git-l10n code reviewJiang Xin, Aug 22, 2021
  3. Bagas SanjayaAug 23, 2021
  4. Jiang XinAug 23, 2021
  5. Johannes SchindelinAug 23, 2021
  6. Junio C HamanoAug 23, 2021
  7. Johannes SchindelinAug 24, 2021
  8. Junio C HamanoAug 24, 2021
  9. Jean-Noël AVILAAug 24, 2021
  10. Jiang XinAug 31, 2021
  11. Jiang XinAug 24, 2021
  12. Junio C HamanoAug 24, 2021
  13. Jiang XinAug 24, 2021
  14. Johannes SchindelinAug 25, 2021
  15. Jiang XinAug 26, 2021
  16. Jeff KingAug 27, 2021
  17. Jiang XinAug 27, 2021
  18. ci: new github-action for git-l10n code reviewJiang Xin, Aug 27, 2021
  19. 1/1 ci: new github-action for git-l10n code reviewJiang Xin, Sep 2, 2021
  20. 0/1 ci: new github-action for git-l10n code reviewJiang Xin, Sep 2, 2021
  21. 0/1 ci: new github-action for git-l10n code reviewJiang Xin, Sep 9, 2021
  22. 1/1 ci: new github-action for git-l10n code reviewJiang Xin, Sep 9, 2021
  23. 1/1 ci: new github-action for git-l10n code reviewJiang Xin, Aug 23, 2021
  24. 0/1 ci: new github-action for git-l10n code reviewJiang Xin, Aug 23, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.