Re: [PATCH 1/1] ci: new github-action for git-l10n code review

From: Jiang Xin <worldhello.net@gmail.com>
Date: Aug 31, 2021, 01:03 UTC
Message-ID: <CANYiYbGwOqm=BLVd-7zFD+5W0_jGaz2yCN0HoQHYnr7wLQSd+Q@mail.gmail.com>
In-Reply-To: <3020682.V8qLCztWNM@cayenne>

On Tue, Aug 31, 2021 at 4:49 AM Jean-Noël AVILA <jn.avila@free.fr> wrote:

Show 15 quoted lines

>
> Le mardi 24 août 2021, 11:27:44 CEST Johannes Schindelin a écrit :
> >
> > The biggest problem is that there are forks of `git-l10n/git-po` that
> > accept PRs in their own right. That is what I tried to address by using
> > just the repository name, without the org/user prefix.
> >
> > Ciao,
> > Dscho
> >
>
> Well, I'm in this case, plus my repo is a fork of git/git.
>
> Would it not possible to formally require the presence of a "dumb" secret to run this rule?
>

It is not supported to use secrets/env in if condition. See this post:

    https://github.community/t/jobs-job-id-if-does-not-work-with-env-secrets/16928

In patch v3, will check both repo name and branch names. See:

    https://lore.kernel.org/git/20210827071320.14183-1-worldhello.net@gmail.com/

-- Jiang Xin