git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] gitweb generates wrong links in grep search results (git_search_files)

From
Jakub Narębski <jnareb@gmail.com>
Date
Jan 4, 2012, 16:21 UTC
Message-ID
<CANQwDwfnp167Uth5TLbCD6OR-Xe6JD-2vENiJVnipi1YdjnMPQ@mail.gmail.com>
In-Reply-To
<7vhb0cqpix.fsf@alter.siamese.dyndns.org>
On Wed, Jan 4, 2012 at 1:28 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> Thomas Perl <th.perl@gmail.com> writes:
>
>> I think I found a bug in gitweb when grep'ing for text in a branch
>> different from "master". Here's how to reproduce it:
>
> Thanks for a detailed report (and thanks for gpodder ;-).
>
> Jakub, care to take a look?

I see the bug: it should be 'hash_base' not 'hash' in href() creating link to "blob" view in git_search_files().

I'll try to send a fix soon...
-- 
Jakub Narebski
Previous: Junio C HamanoNext: Jakub Narebski
Message 3 of 7 in “[BUG] gitweb generates wrong links in grep search results (git_search_files)”
  1. Thomas PerlJan 2, 2012
  2. Junio C HamanoJan 4, 2012
  3. Jakub NarębskiJan 4, 2012
  4. 1/2 gitweb: Fix file links in "grep" searchJakub Narebski, Jan 5, 2012
  5. 2/2 gitweb: Harden "grep" search against filenames with ':'Jakub Narebski, Jan 5, 2012
  6. Thomas PerlJan 13, 2012
  7. Junio C HamanoJan 13, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.