Re: [PATCH 1/2] gitweb: Fix file links in "grep" search
- From
Thomas Perl <th.perl@gmail.com>
- Date
- Jan 13, 2012, 14:09 UTC
- Message-ID
- <CA+uOhx7QwRQJzyYBCkmVDBRCMt0i_ZqS=sfTG0VmNiVv2dVoww@mail.gmail.com>
- In-Reply-To
- <201201052126.49087.jnareb@gmail.com>
Hi,
2012/1/5 Jakub Narebski <jnareb@gmail.com>:
Show 10 quoted lines
> There were two bugs in generating file links (links to "blob" view),
> one hidden by the other. The correct way of generating file link is
>
> href(action=>"blob", hash_base=>$co{'id'},
> file_name=>$file);
>
> It was $co{'hash'} (this key does not exist, and therefore this is
> undef), and 'hash' instead of 'hash_base'.
> [...]
> Thomas, could you check if this fixes your issue?Sorry for taking a bit longer to respond on this one, but I just got around to test all problematic cases that I described with the patch applied - it fixes the problem for me (i.e. I can successfully grep in non-master branches and then clicking the link brings me to the right location).
As far as I'm concerned, the patch can be applied and fixes the bug.
Thanks for the quick fix! :) Thomas