Re: [PATCH 4/4] gitweb: make search help link less ugly

From: Jakub Narębski <jnareb@gmail.com>
Date: Aug 3, 2013, 21:37 UTC
Message-ID: <CANQwDwdcCUNBZH=YbSjwTZx6vau_cs89EH9FV8OUQcdNzDE5DQ@mail.gmail.com>
In-Reply-To: <E1Uyeth-0003TF-Kx@hermes-2.csi.cam.ac.uk>

On Tue, Jul 9, 2013 at 7:15 PM, Tony Finch <dot@dotat.at> wrote:

> The search help link was a superscript question mark right next to
> a drop-down menu, which looks misaligned

I think the idea was to simulate footnote explaining search terms (I think, I am not the author of this feature)...

>                                                                and is a cramped and
> awkward click target. Remove the superscript tags and add some
> spacing to fix these nits. Add a title attribute to provide an
> explanatory mouseover.

... but I agree that it makes for poor UI.

Show 18 quoted lines

>
> Signed-off-by: Tony Finch <dot@dotat.at>
> ---
>  gitweb/gitweb.perl | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index c029b98..874c948 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -4029,9 +4029,9 @@ sub print_search_form {
>               $cgi->input({-name=>"a", -value=>"search", -type=>"hidden"}) . "\n" .
>               $cgi->input({-name=>"h", -value=>$search_hash, -type=>"hidden"}) . "\n" .
>               $cgi->popup_menu(-name => 'st', -default => 'commit',
> -                              -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) .
> -             $cgi->sup($cgi->a({-href => href(action=>"search_help")}, "?")) .
> -             " search:\n",
> +                              -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) .

Nb. what changed here (in line above)?

Show 7 quoted lines

> +             " " . $cgi->a({-href => href(action=>"search_help"),
> +                            -title => "search help" }, "?") . " search:\n",
>               $cgi->textfield(-name => "s", -value => $searchtext, -override => 1) . "\n" .
>               "<span title=\"Extended regular expression\">" .
>               $cgi->checkbox(-name => 'sr', -value => 1, -label => 're',
> --
> 1.8.3.1.605.g85318f5