Re: [PATCH 3/4] gitweb: omit the repository owner when it is unset
- From
Jakub Narębski <jnareb@gmail.com>
- Date
- Aug 3, 2013, 21:40 UTC
- Message-ID
- <CANQwDwdA5VnywJmoNpCX7s=hH7tmUDUmRuak12W7BXOQtqRoQw@mail.gmail.com>
- In-Reply-To
- <E1Uyete-0003Sv-OI@hermes-2.csi.cam.ac.uk>
On Tue, Jul 2, 2013 at 6:24 PM, Tony Finch <dot@dotat.at> wrote:
> On the repository summary page, leave the whole owner line out if > the repo does not have an owner, rather than displaying a labelled > empty field..
Note that if $omit_owner is true, whole _column_ is skipped.
Is removing cell (instead of leaving it empty) and relying on browser treating nonexistent cell correctly a good idea, that I do not know. Does it looks better? Does it looks better in all web browsers?
Show 21 quoted lines
> Signed-off-by: Tony Finch <dot@dotat.at>
> ---
> gitweb/gitweb.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 8d69ada..c029b98 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -6463,7 +6463,7 @@ sub git_summary {
> print "<div class=\"title\"> </div>\n";
> print "<table class=\"projects_list\">\n" .
> "<tr id=\"metadata_desc\"><td>description</td><td>" . esc_html($descr) . "</td></tr>\n";
> - unless ($omit_owner) {
> + if ($owner and not $omit_owner) {
> print "<tr id=\"metadata_owner\"><td>owner</td><td>" . esc_html($owner) . "</td></tr>\n";
> }
> if (defined $cd{'rfc2822'}) {
> --
> 1.8.3.1.605.g85318f5
>-- Jakub Narebski