git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 2/4] gitweb: Return 1 on validation success instead of passed input

From
Jakub Narębski <jnareb@gmail.com>
Date
Dec 11, 2013, 16:08 UTC
Message-ID
<CANQwDwc5iagW+yLxG-DempZuoNk7Nc0W4rg8ZXA_bU=Eu2vTiA@mail.gmail.com>
In-Reply-To
<1386762884-7564-3-git-send-email-krzesimir@endocode.com>

On Wed, Dec 11, 2013 at 12:54 PM, Krzesimir Nowak <krzesimir@endocode.com> wrote:

> Users of validate_* passing "0" might get failures on correct name
> because of coercion of "0" to false in code like:
> die_error(500, "invalid ref") unless (check_ref_format ("0"));

Very minor issue: there is no check_ref_format() after v7; perhaps validate_pathname / is_valid_pathname

> Also, the validate_foo subs are renamed to is_valid_foo.

is_valid_foo is better than validate_foo IMVHO, though still not perfect (it does some validation, but complete validation is done by git command).

>
> Signed-off-by: Krzesimir Nowak <krzesimir@endocode.com>
-- 
Jakub Narebski
Previous: Krzesimir NowakNext: Krzesimir Nowak
Message 4 of 7 in “Show extra branch refs in gitweb”
  1. 0/4 Show extra branch refs in gitwebKrzesimir Nowak, Dec 11, 2013
  2. 1/4 gitweb: Move check-ref-format code into separate functionKrzesimir Nowak, Dec 11, 2013
  3. 2/4 gitweb: Return 1 on validation success instead of passed inputKrzesimir Nowak, Dec 11, 2013
  4. Jakub NarębskiDec 11, 2013
  5. 3/4 gitweb: Add a feature for adding more branch refsKrzesimir Nowak, Dec 11, 2013
  6. 4/4 gitweb: Denote non-heads, non-remotes branchesKrzesimir Nowak, Dec 11, 2013
  7. Junio C HamanoDec 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.