From: Jakub Narębski <jnareb@gmail.com>
Date: Wed, 11 Dec 2013 16:08:39 GMT
Subject: Re: [PATCH v7 2/4] gitweb: Return 1 on validation success instead of passed input
Message-ID: <CANQwDwc5iagW+yLxG-DempZuoNk7Nc0W4rg8ZXA_bU=Eu2vTiA@mail.gmail.com>
In-Reply-To: <1386762884-7564-3-git-send-email-krzesimir@endocode.com>

On Wed, Dec 11, 2013 at 12:54 PM, Krzesimir Nowak
<krzesimir@endocode.com> wrote:

> Users of validate_* passing "0" might get failures on correct name
> because of coercion of "0" to false in code like:
> die_error(500, "invalid ref") unless (check_ref_format ("0"));

Very minor issue: there is no check_ref_format() after v7; perhaps
validate_pathname / is_valid_pathname

> Also, the validate_foo subs are renamed to is_valid_foo.

is_valid_foo is better than validate_foo IMVHO, though still not perfect
(it does some validation, but complete validation is done by git command).

>
> Signed-off-by: Krzesimir Nowak <krzesimir@endocode.com>

-- 
Jakub Narebski