Re: [Ksummit-2013-discuss] [PATCH] commit: Add -f, --fixes <commit> option to add Fixes: line

From: Michel Lespinasse <walken@google.com>
Date: Oct 27, 2013, 08:03 UTC
Message-ID: <CANN689HctBYZfU+OQ7movFFWNm6rwUdU7G-ExxhPcBPg1KF8Jw@mail.gmail.com>
In-Reply-To: <20131027071407.GA11683@leaf>

On Sun, Oct 27, 2013 at 12:14 AM, Josh Triplett <josh@joshtriplett.org> wrote:

Show 15 quoted lines

>> > +-f <commit>::
>> > +--fixes=<commit>::
>> > +   Add Fixes line for the specified commit at the end of the commit
>> > +   log message.  This line includes an abbreviated commit hash for
>> > +   the specified commit; the `core.abbrev` option determines the
>> > +   length of the abbreviated commit hash used, with a minimum length
>> > +   of 12 hex digits.
>>
>> You might also mention that the "Fixes:" line includes the old commit's
>> subject line.
>
> I only mentioned the abbreviated commit hash because it was necessary to
> explain the factors affecting hash length.  -s, above, doesn't mention
> that the Signed-off-by line includes the name and email address of the
> committer.

I do wonder, if we're going to bake into git the idea that too-short abbreviated sha1s don't make sense, why don't we just change the core.abbrev default to 12 everywhere rather than just in this one command ?

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.