git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodule-config: use hashmap_iter_init()

From
Alexander Kuleshov <kuleshovmail@gmail.com>
Date
Mar 15, 2016, 19:10 UTC
Message-ID
<CANCZXo7OBe_+udjGXQbe6YpZK8Ln113J=PZ59MnwQq7E8jwYLA@mail.gmail.com>
In-Reply-To
<CAGZ79kZH_xzfvo=cP_+BdsqpthwQUKkJjo7OawkpFN9y+jm_+w@mail.gmail.com>
On Wed, Mar 16, 2016 at 1:08 AM, Stefan Beller <sbeller@google.com> wrote:
> The change looks correct to me. But as Eric said, the commit message
> needs work and a sign off. With that,
> Reviewed-by: Stefan Beller <sbeller@google.com>

Ah, yes, forgot to pass `-s` to commit command. Sorry for noise guys, will resend the patch.

Previous: Stefan Beller
Message 4 of 4 in “submodule-config: use hashmap_iter_init()”
  1. submodule-config: use hashmap_iter_init()Alexander Kuleshov, Mar 15, 2016
  2. Eric SunshineMar 15, 2016
  3. Stefan BellerMar 15, 2016
  4. Alexander KuleshovMar 15, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.