From: Alexander Kuleshov Date: Tue, 15 Mar 2016 19:10:18 GMT Subject: Re: [PATCH] submodule-config: use hashmap_iter_init() Message-ID: In-Reply-To: On Wed, Mar 16, 2016 at 1:08 AM, Stefan Beller wrote: > The change looks correct to me. But as Eric said, the commit message > needs work and a sign off. With that, > Reviewed-by: Stefan Beller Ah, yes, forgot to pass `-s` to commit command. Sorry for noise guys, will resend the patch.