Re: [PATCH] column: show auto columns when pager is active
- From
- Martin Ågren <martin.agren@gmail.com>
- Date
- Oct 11, 2017, 19:02 UTC
- Message-ID
- <CAN0heSqJuE5RorQSf8yX3TF_giqL-Mt+DJ5-V08eH3=xi+Q9wA@mail.gmail.com>
- In-Reply-To
- <20171011183640.GC16800@alpha.vpn.ikke.info>
On 11 October 2017 at 20:36, Kevin Daudt <me@ikke.info> wrote:
Show 10 quoted lines
> On Wed, Oct 11, 2017 at 08:12:35PM +0200, Martin Ågren wrote: >> On 11 October 2017 at 19:23, Kevin Daudt <me@ikke.info> wrote: >> I wonder if it's useful to set COLUMNS a bit lower so that this has to >> split across more than one line (but not six), i.e., to do something >> non-trivial. I suppose that might lower the chances of some weird >> breakage slipping through. > > Yeah, I was doubting about that, but wouldn't this amount to testing > whether git column is working properly, instead of just testing whether > it's being done at all?
Right, I think you'd need a pretty crazy bug in order to slip through all tests here.
Show 6 quoted lines
>> These were just the thoughts that occurred to me, not sure if any of >> them is particularly significant. Thanks for cleaning up after me. >> > > np. Just as I posted earlier, I think you did not actually cause the bug > (because this has never worked), it just made it visible to more users.
Well, the general bug/behavior was always there, but I regressed a particular use-case. In 2.14, you could do `git tag` with column.ui=auto and it would do the columns-thing. But with ff1e72483, the behavior changed. To add insult to injury, it might be non-obvious that the pager is running, since with just a few tags, the pager simply exits silently. So debugging this could probably be quite frustrating.
Martin