Re: [PATCH v2] column: show auto columns when pager is active

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 24, 2017, 01:18 UTC
Message-ID: <20171024011803.tgigclx2swfg744r@aiede.mtv.corp.google.com>
In-Reply-To: <xmqqy3o19wp5.fsf@gitster.mtv.corp.google.com>

Junio C Hamano wrote:

Show 10 quoted lines

> Subject: column: do not include pager.c
>
> Everything this file needs from the pager API (e.g. term_columns(),
> pager_in_use()) is already declared in the header file it includes.
>
> Noticed-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  column.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

Show 10 quoted lines

> --- a/column.c
> +++ b/column.c
> @@ -5,7 +5,6 @@
>  #include "parse-options.h"
>  #include "run-command.h"
>  #include "utf8.h"
> -#include "pager.c"
>  
>  #define XY2LINEAR(d, x, y) (COL_LAYOUT((d)->colopts) == COL_COLUMN ? \
>  			    (x) * (d)->rows + (y) : \