Re: [PATCH 24/44] t3200: mark assertion with SHA1 prerequisite
- From
- Martin Ågren <martin.agren@gmail.com>
- Date
- May 16, 2020, 11:04 UTC
- Message-ID
- <CAN0heSpKG_2F_WFP6c7WoppEwoQ7Pjbik152+8_hcz70C3i2MQ@mail.gmail.com>
- In-Reply-To
- <20200513005424.81369-25-sandals@crustytoothpaste.net>
On Wed, 13 May 2020 at 02:56, brian m. carlson <sandals@crustytoothpaste.net> wrote:
Show 5 quoted lines
> > One of the test assertions in this test checks that git branch -m works > even without a .git/config file. However, if the repository requires > configuration extensions, such as because it uses a non-SHA-1 algorithm, > this assertion will fail. Mark the assertion as requiring SHA-1.
Makes sense.
Show 5 quoted lines
> -test_expect_success 'git branch -m q q2 without config should succeed' ' > +test_expect_success SHA1 'git branch -m q q2 without config should succeed' ' > git branch -m q q2 && > git branch -m q2 q > '
Going forward, we might need config files for other reasons (reftable?), meaning this would become "SHA1,!REFTABLE". So maybe this should be "!CONFIG_EXTENSIONS" or "CONFIG_LESS". I think this is ok for now, though. When/if someone needs to make another fix like this here -- or at the very least the *third* time around -- that's when we should think a bit bigger.
Martin