Re: [PATCH 20/44] t5562: pass object-format in synthesized test data

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: May 16, 2020, 19:50 UTC
Message-ID: <20200516195001.GF6362@camp.crustytoothpaste.net>
In-Reply-To: <CAN0heSqVrOTpSpptqe+zu+9-qQVYAL=jcx7tas3pNRcSVH+auQ@mail.gmail.com>

On 2020-05-16 at 10:55:33, Martin Ågren wrote:

Show 13 quoted lines

> On Wed, 13 May 2020 at 02:56, brian m. carlson
> <sandals@crustytoothpaste.net> wrote:
> >
> > Ensure that we pass the object-format capability in the synthesized test
> > data so that this test works with algorithms other than SHA-1.
> 
> Right.
> 
> > In addition, add an additional test using the old data for when we're
> > using SHA-1 so that we can be sure that we preserve backwards
> > compatibility with servers not offering the object-format capability.
> 
> I'll have some questions on this below.

I think this got dropped in the rebase.

Show 6 quoted lines

> Hmmm. Isn't this an exact copy of the 'push plain' test immediately
> preceding it? The commit message talks about using the "old data"
> (i.e., without "object-format=%s"?). Should this test use a variant of
> push_body where we're not adding "object-format"? I'm not sure I grok
> what exactly we want to test here.. And does it really belong in
> t/t*-content-length.sh?

It is.  I'll probably drop this part of the patch.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204