Re: [PATCH 3/5] diff --color-moved-ws: fix a memory leak

From: Martin Ågren <martin.agren@gmail.com>
Date: Oct 3, 2018, 09:54 UTC
Message-ID: <CAN0heSpF_5WSHWWwFYnQYWhwMopjOSB8JvKh2DYhRORjDN_jdA@mail.gmail.com>
In-Reply-To: <20181002175514.31495-3-phillip.wood@talktalk.net>

On Tue, 2 Oct 2018 at 20:04, Phillip Wood <phillip.wood@talktalk.net> wrote:

Show 14 quoted lines

>         const struct emitted_diff_symbol *longer =  a->len > b->len ? a : b;
>         const struct emitted_diff_symbol *shorter = a->len > b->len ? b : a;
>         int d = longer->len - shorter->len;
> +       int ret = !strncmp(longer->line + d, shorter->line, shorter->len);
> +
> +       if (!ret)
> +               return ret;
>
>         out->string = xmemdupz(longer->line, d);
>         out->current_longer = (a == longer);
>
> -       return !strncmp(longer->line + d, shorter->line, shorter->len);
> +       return ret;
>  }

The caller only cares about 0 vs non-0, so this would also work:

   if (strncmp(...))
           return 0;

...

   return 1;

Just a thought, to avoid some "!"s and the new variable `ret`.

Martin