Re: [PATCH 3/5] diff --color-moved-ws: fix a memory leak

From: Phillip Wood <phillip.wood@talktalk.net>
Date: Oct 3, 2018, 09:42 UTC
Message-ID: <5821aa37-b1aa-9118-5920-cfa60b243032@talktalk.net>
In-Reply-To: <CAGZ79kbX+DssZaCS_fV-eNR828Yd-vsLJ6F58Lifn2f8j+oXvA@mail.gmail.com>

On 02/10/2018 20:08, Stefan Beller wrote:

Show 16 quoted lines

> On Tue, Oct 2, 2018 at 10:55 AM Phillip Wood <phillip.wood@talktalk.net> wrote:
>>
>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>
>> Don't duplicate the indentation string if we're not going to use it.
>> This was found with asan.
> 
> Makes sense,
> 
> Thanks,
> Stefan
> 
> With compute_ws_delta growing bigger here (and having only one caller),
> I wonder if we want to pass 'match' instead of match->es (and pmb_nr),
> such that the function can also take care of
>     pmb[pmb_nr++].match = match;

Wouldn't we still need to increment pmb_nr in the caller though, in which case I'm not sure it saves much.

> Then the function is not a mere compute_ws_delta, but a whole
> setup_new_pmb(...) thing. Undecided.
>