Re: [PATCH v3] commit-tree: add missing --gpg-sign flag

From: Martin Ågren <martin.agren@gmail.com>
Date: Jan 19, 2019, 16:48 UTC
Message-ID: <CAN0heSocQu+w9V3HUJDQVtFZ-NT++dubyt49QOMfvHpJSfNgZA@mail.gmail.com>
In-Reply-To: <20190119154552.12189-1-martin.agren@gmail.com>

On Sat, 19 Jan 2019 at 16:46, Martin Ågren <martin.agren@gmail.com> wrote:

Show 11 quoted lines

>         # commit.gpgsign is still on but this must not be signed
> -       git tag ninth-unsigned $(echo 9 | git commit-tree HEAD^{tree}) &&
> +       echo 9 | git commit-tree HEAD^{tree} >oid &&
> +       test_line_count = 1 oid &&
> +       git tag ninth-unsigned $(cat oid) &&
>         # explicit -S of course must sign.
> -       git tag tenth-signed $(echo 9 | git commit-tree -S HEAD^{tree})
> +       echo 10 | git commit-tree -S HEAD^{tree} >oid &&
> +       test_line_count = 1 oid &&
> +       git tag tenth-signed $(cat oid)
>  '

Or, a bit simpler:

  oid=$(echo 10 | git commit-tree -S HEAD^{tree}) &&
  git tag tenth-signed "$oid"

Martin