Re: [PATCH v3] commit-tree: add missing --gpg-sign flag

From: Brandon Richardson <brandon1024.br@gmail.com>
Date: Jan 19, 2019, 23:18 UTC
Message-ID: <CAETBDP5xgPwu9ejg3j0oZGpwN0T1Me0n0CiaaCtrK37pZrJgZw@mail.gmail.com>
In-Reply-To: <CAN0heSo7CmuAYJGK5RjRkT9TX+RUyNDk-Rp_n-OCN8q1O6xNzA@mail.gmail.com>

Hi Martin,

On Sat, 19 Jan 2019 at 17:19, Martin Ågren <martin.agren@gmail.com> wrote:

Show 9 quoted lines

> > > Or, a bit simpler:
> > >
> > >   oid=$(echo 10 | git commit-tree -S HEAD^{tree}) &&
> > >   git tag tenth-signed "$oid"
> >
> > Just noticed your latest email. Do you prefer it this way?
>
> I think so, yeah. (But who knows what others might prefer? ;-) )
>

I'm personally a fan of your initial patch, I found it to be quite elegant. I think I'll submit your first version, and if people prefer another way we will go in that direction.

> I think the cleanest would be to submit a two-patch series, v4.

For simplicity, I'll do that :-)

Brandon