Re: [PATCH] l10n: de.po: translate 2 new messages

From: Ralf Thielow <ralf.thielow@gmail.com>
Date: Nov 18, 2014, 13:37 UTC
Message-ID: <CAN0XMOLPN6ojrpR5VWw7jCwe-L6N8EELXyiSmkzsyBMPjmjxCA@mail.gmail.com>
In-Reply-To: <1416153257-2407-1-git-send-email-phillip.szelat@gmail.com>

Hi Phillip,

2014-11-16 16:54 GMT+01:00 Phillip Sz <phillip.szelat@gmail.com>:

> Phillip

There's no need for writing your name in the commit message body.

Show 17 quoted lines

>
> Signed-off-by: Phillip Sz <phillip.szelat@gmail.com>
> ---
>  po/de.po | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/po/de.po b/po/de.po
> index c807967..5af3f8f 100644
> --- a/po/de.po
> +++ b/po/de.po
> @@ -5473,7 +5473,7 @@ msgstr "prüft die Reflogs (Standard)"
>
>  #: builtin/fsck.c:613
>  msgid "also consider packs and alternate objects"
> -msgstr ""
> +msgstr "ziehen Sie außerdem Pakete und alternative Objekte in Betracht"
>

Your message has a different style than other messages of this type. I wouldn't address the user directly and would write it as:

msgstr "ebenso Pakete und alternative Objekte betrachten"

What do you think?

Show 9 quoted lines

>  #: builtin/fsck.c:614
>  msgid "enable more strict checking"
> @@ -8253,7 +8253,7 @@ msgstr "Referenz muss sich auf dem angegebenen Wert befinden"
>
>  #: builtin/push.c:495
>  msgid "check"
> -msgstr ""
> +msgstr "Überprüfung"
>

Hm. If I understand it correctly, "check" is one option of the --recurse-submodules parameter for git-push, the other one is "on-demand". Since the possible values are either "check" or "on-demand", we shouldn't translate this string at all and should just write "check|on-demand" as shown in "git help push".

Perhaps this message need to be adjusted and excluded from translation. I dunno.

Show 5 quoted lines

>  #: builtin/push.c:496
>  msgid "control recursive pushing of submodules"
> --
> 2.1.3
>