Re: [PATCH 2/2] color: support "default" to restore fg/bg color

From: Robert Estelle <robertestelle@gmail.com>
Date: Oct 26, 2021, 00:54 UTC
Message-ID: <CAMmwyQor1AekB9cCUE3osLJeb2r_w0q0T1JqUcNFk6L=7O2-Jg@mail.gmail.com>
In-Reply-To: <xmqqr1c8zpmw.fsf@gitster.g>

Those are good examples. Note that this applies to more cases than those relying on transparency or patterns: color terms often have defaults that are not identical to their ANSI palette. I suspect *most* themes are probably this way, based on a quick sampling.

You can see a bunch of examples here: https://github.com/mbadolato/iTerm2-Color-Schemes#screenshots in all the themes where the background color in the "40m" column isn't the same as the unset column before it. (All of Terminal.app's built-in themes are that way; I know xterm defaults to black on white vs white on black; and so on).

Best, Robert

On Mon, Oct 25, 2021 at 3:49 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

>
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > For an example of why this differs from white on black, let me mention
> > that I use a semi-transparent terminal, where a black background is
> > opaque black, and the default is semi-transparent.  I assume other
> > possibilities include patterned backgrounds (Enlightenment, anyone?).
> > Whether you want to include something to this effect in the commit
> > message is up to you, but I provide it for the interested reader.
>
> It would help support the description of the cause, I would think.
>
> I am also OK with these changes.  [1/2] is good for completeness,
> and being able to say "go back to the default" without having to
> know what the default is with [2/2] is also a good change.
>
> Thanks, both.