git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] color: add missing GIT_COLOR_* white/black constants

From
Robert Estelle via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 25, 2021, 22:32 UTC
Message-ID
<733fae23d1cef11410befdf514a2360a420a4c62.1635201156.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1116.git.git.1635201156.gitgitgadget@gmail.com>
From: Robert Estelle <robertestelle@gmail.com>

The colors black and white where conspicuously missing from the color constants. Although they are not currently used in the codebase, having them included makes it easier to visually verify the ANSI codes, and to distinguish them explicitly from "GIT_COLOR_DEFAULT" in a subsequent change.

Signed-off-by: Robert Estelle <robertestelle@gmail.com>
---
 color.h | 8 ++++++++
 1 file changed, 8 insertions(+)
diff --git a/color.h b/color.h
index 98894d6a175..c20d324e7ca 100644
--- a/color.h
+++ b/color.h
@@ -24,30 +24,38 @@ struct strbuf;
 #define GIT_COLOR_NORMAL	""
 #define GIT_COLOR_RESET		"\033[m"
 #define GIT_COLOR_BOLD		"\033[1m"
+#define GIT_COLOR_BLACK		"\033[30m"
 #define GIT_COLOR_RED		"\033[31m"
 #define GIT_COLOR_GREEN		"\033[32m"
 #define GIT_COLOR_YELLOW	"\033[33m"
 #define GIT_COLOR_BLUE		"\033[34m"
 #define GIT_COLOR_MAGENTA	"\033[35m"
 #define GIT_COLOR_CYAN		"\033[36m"
+#define GIT_COLOR_WHITE		"\033[37m"
+#define GIT_COLOR_BOLD_BLACK	"\033[1;30m"
 #define GIT_COLOR_BOLD_RED	"\033[1;31m"
 #define GIT_COLOR_BOLD_GREEN	"\033[1;32m"
 #define GIT_COLOR_BOLD_YELLOW	"\033[1;33m"
 #define GIT_COLOR_BOLD_BLUE	"\033[1;34m"
 #define GIT_COLOR_BOLD_MAGENTA	"\033[1;35m"
 #define GIT_COLOR_BOLD_CYAN	"\033[1;36m"
+#define GIT_COLOR_BOLD_WHITE	"\033[1;37m"
+#define GIT_COLOR_FAINT_BLACK	"\033[2;30m"
 #define GIT_COLOR_FAINT_RED	"\033[2;31m"
 #define GIT_COLOR_FAINT_GREEN	"\033[2;32m"
 #define GIT_COLOR_FAINT_YELLOW	"\033[2;33m"
 #define GIT_COLOR_FAINT_BLUE	"\033[2;34m"
 #define GIT_COLOR_FAINT_MAGENTA	"\033[2;35m"
 #define GIT_COLOR_FAINT_CYAN	"\033[2;36m"
+#define GIT_COLOR_FAINT_WHITE	"\033[2;37m"
+#define GIT_COLOR_BG_BLACK	"\033[40m"
 #define GIT_COLOR_BG_RED	"\033[41m"
 #define GIT_COLOR_BG_GREEN	"\033[42m"
 #define GIT_COLOR_BG_YELLOW	"\033[43m"
 #define GIT_COLOR_BG_BLUE	"\033[44m"
 #define GIT_COLOR_BG_MAGENTA	"\033[45m"
 #define GIT_COLOR_BG_CYAN	"\033[46m"
+#define GIT_COLOR_BG_WHITE	"\033[47m"
 #define GIT_COLOR_FAINT		"\033[2m"
 #define GIT_COLOR_FAINT_ITALIC	"\033[2;3m"
 #define GIT_COLOR_REVERSE	"\033[7m"
-- 
gitgitgadget
Previous: Robert Estelle via GitGitGadgetNext: Robert Estelle via GitGitGadget
Message 2 of 8 in “color: support "default" to restore fg/bg color”
  1. 0/2 color: support "default" to restore fg/bg colorRobert Estelle via GitGitGadget, Oct 25, 2021
  2. 1/2 color: add missing GIT_COLOR_* white/black constantsRobert Estelle via GitGitGadget, Oct 25, 2021
  3. 2/2 color: support "default" to restore fg/bg colorRobert Estelle via GitGitGadget, Oct 25, 2021
  4. brian m. carlsonOct 25, 2021
  5. Junio C HamanoOct 25, 2021
  6. Robert EstelleOct 26, 2021
  7. Junio C HamanoOct 28, 2021
  8. Robert EstelleOct 28, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.