Re: [GSoC] Unify ref-filter formats with other --pretty formats

From: Kapil Jain <jkapil.cs@gmail.com>
Date: Mar 31, 2019, 17:45 UTC
Message-ID: <CAMknYEPN2rPsX8CcJVosi-S1W8bLTmMMvgS8E-SwyR74gevtcA@mail.gmail.com>
In-Reply-To: <CAMknYENqM1Q_2v+0_DJtw41M85otpYzbVbbKPyh2NVZ++u=fpg@mail.gmail.com>

On Fri, Mar 29, 2019 at 7:23 PM Kapil Jain <jkapil.cs@gmail.com> wrote:

Show 11 quoted lines

>
> On Thu, Mar 28, 2019 at 11:14 PM Olga Telezhnaya
> <olyatelezhnaya@gmail.com> wrote:
> >
> > Unfortunately, I can't consult you properly about structure of
> > pretty.c. I guess that would be your first task of the internship to
> > dive into it and think how to improve it. By the way, you could try to
> > make more detailed documentation and that could be one of your first
> > contributions. It will help you to understand the system better, and
> > other contributors will be happy to read it.
>

i traced the cmd_log() to understand the point at which pretty.c could be used, i only got to userformat_find_requirements().

struct userformat_want {
    unsigned notes:1;
    unsigned source:1;
};

what are notes and source flags used for ?

olga: what approach did you follow to figure which logic in cat-file was redundant and that ref-filter could be reused there ? does it include picking any file, go through it entirely and then pick places to be replaced by ref-filter logic ?