Re: [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts
On Fri, Mar 29, 2019 at 3:00 AM Thomas Gummerer <t.gummerer@gmail.com> wrote:
Show 6 quoted lines
>
>
> I had previously mentioned that this project was attempted already in
> my email at [*1*]. Did you take a look at the thread I linked to
> there, and the regex used? I still feel like that previous experience
> is something you could learn from.
I saw it, and the regex i have used is a little different from that one.
Show 10 quoted lines
> But that said, I think your assumption in the other email that the
> output should be
>
> [-$TEST_DIRECTORY-]
> {+$TEST_DIR+}
>
> might not be correct. The tests are using 'git diff
> --word-diff=color', rather than 'git diff --word-diff=plain'. Only
> the latter would add the [- -] and {+ +} around the changed words,
> while the former adds the color, which the tests are testing for.This makes sense, i will write more tests for this.