git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts

From
Thomas Gummerer <t.gummerer@gmail.com>
Date
Mar 29, 2019, 19:07 UTC
Message-ID
<20190329190741.GM32487@hank.intra.tgummerer.com>
In-Reply-To
<CAMknYEM3Tff7Z5HcdNT9-RDTf53RHi1_scpO8JVo3pAD3-0xSw@mail.gmail.com>
On 03/29, Kapil Jain wrote:
Show 9 quoted lines
> On Fri, Mar 29, 2019 at 3:00 AM Thomas Gummerer <t.gummerer@gmail.com> wrote:
> >
> >
> > I had previously mentioned that this project was attempted already in
> > my email at [*1*].  Did you take a look at the thread I linked to
> > there, and the regex used?  I still feel like that previous experience
> > is something you could learn from.
> 
> I saw it, and the regex i have used is a little different from that one.

Right, so one thing you should definitely do is to compare the regex there and the regex you have, and understand why there are differences when they are trying to do the same thing. Using that knowledge you should be able to improve the regex in your patch as well.

Previous: Kapil JainNext: Kapil Jain
Message 8 of 9 in “userdiff: added support for diffing shell scripts”
  1. Kapil JainMar 22, 2019
  2. Christian CouderMar 23, 2019
  3. Kapil JainMar 24, 2019
  4. Christian CouderMar 24, 2019
  5. Kapil JainMar 24, 2019
  6. Thomas GummererMar 28, 2019
  7. Kapil JainMar 29, 2019
  8. Thomas GummererMar 29, 2019
  9. [GSoC][RFC/PATCH 2/2] userdiff: added shell script support, clears testKapil Jain, Mar 24, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.