Re: [PATCH v2] credential-osxkeychain: support more protocols

From: Xidorn Quan <quanxunzhen@gmail.com>
Date: May 27, 2013, 15:46 UTC
Message-ID: <CAMdq69_RarEXDdR+xzvSb9YPCR2hE=0tM3o-mF3d=cgDMWSq8A@mail.gmail.com>
In-Reply-To: <20130527150855.GA8250@sigill.intra.peff.net>

On Mon, May 27, 2013 at 11:08 PM, Jeff King <peff@peff.net> wrote: [snip]

Show 9 quoted lines

>
> This looks good to me. Git will ask for "protocol=ftp" when
> accessing the dumb protocol over ftp. And it will ask for smtp via
> git-send-email since 4d31a44 (git-send-email: use git credential to
> obtain password, 2013-02-12).
>
> While we are in the area it may be worth thinking if there are other
> schemes we would want to support. Git might feed any URL scheme that
> curl accepts, so I think we would want to handle FTPS alongside FTP, no?

Good point, I'll add that.

> We may also eventually want IMAP for git-imap-send, but we have not yet
> implemented credential-helper support there. We may also want http/socks
> proxy authentication, but we also have not implemented the git side of
> that yet. So I think both of those can wait for now.

Hope the helpers will be implemented soon. IMO, we can add IMAP and SOCKS for now since the protocol names are clear, while it is unclear what protocol name will be used for HTTP/HTTPS proxy. I guess that some may prefer using http/https as protocol name instead of something specific. What do you think?

-- Xidorn Quan