Re: [PATCH] credential-osxkeychain: support more protocols
- From
Xidorn Quan <quanxunzhen@gmail.com>
- Date
- May 27, 2013, 15:02 UTC
- Message-ID
- <CAMdq699G4bZSEQmZorRfOR87RZ7YGdNnkh_oP4rDZXXauOpDnQ@mail.gmail.com>
- In-Reply-To
- <CAEBDL5XMamYoZFgFWeRr3KTZWZATKp=prFus_44UEMV8LEEtzw@mail.gmail.com>
On Mon, May 27, 2013 at 10:28 PM, John Szakmeister <john@szakmeister.net> wrote: [snip]
Show 19 quoted lines
> > You'll need to read Documentation/SubmittingPatches (here's a link to > a version online: > https://github.com/git/git/blob/master/Documentation/SubmittingPatches). > > You should resend this patch with the fix and change "[PATCH]" to > "[PATCH v2]", so the folks involved know that this is the second > iteration. You also need to include a "Signed-off-by" line in your > patch, which means you agree to the agreement set forth in the > "Developer's Certificate of Origin" (which is in the SubmittingPatches > documentation). You can easily include this line when you make the > commit by using the `-s` option on `git commit`. > > You can also add an "Acked-by" line for me (since I reviewed and > approve of the change): > > Acked-by: John Szakmeister <john@szakmeister.net> > > HTH!
Thx for your explaining, it helps a lot!
After reading the doc, I have a question that when can I affirm that the list reaches a consensus?
-- Xidorn Quan