git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH v4 5/6] completion: calculate argument position properly

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 7, 2012, 21:01 UTC
Message-ID
<CAMP44s3rC6bT3rjrBFdnywwsp5NrXt54L5L-7oKZ=bNFKccq+w@mail.gmail.com>
In-Reply-To
<7v7gwn6cmv.fsf@alter.siamese.dyndns.org>
On Mon, May 7, 2012 at 8:59 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Mon, May 7, 2012 at 3:23 AM, Felipe Contreras
>> <felipe.contreras@gmail.com> wrote:
>>
>>> @@ -2642,6 +2642,8 @@ _git ()
>>>                return
>>>        fi
>>>
>>> +       (( cmd_pos = c + 1 ))
>>
>> Actually, I would prefer cmd_pos=$((c + 1)).
>
> Yeah, that would feel more natural.
>
> Together with 4/6, I am guessing that you are using $cmd and $cmd_pos as a
> global variable to pass state to/from helper functions.  Are they properly
> documented in code (if not, please do so)?

Like cur, prev, words, and cwords? Wait a second... they are not documented anywhere. I'm also not going to work on this... not my itch.

-- 
Felipe Contreras
Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 18 in “completion: __git_complete and other stuff”
  1. 0/6 completion: __git_complete and other stuffFelipe Contreras, May 7, 2012
  2. 1/6 completion: add new __git_complete helperFelipe Contreras, May 7, 2012
  3. SZEDER GáborMay 7, 2012
  4. Junio C HamanoMay 7, 2012
  5. Felipe ContrerasMay 7, 2012
  6. 2/6 tests: add more bash completion testsFelipe Contreras, May 7, 2012
  7. 3/6 completion: simplify _git_bundleFelipe Contreras, May 7, 2012
  8. 4/6 completion: simplify command stuffFelipe Contreras, May 7, 2012
  9. SZEDER GáborMay 7, 2012
  10. 5/6 completion: calculate argument position properlyFelipe Contreras, May 7, 2012
  11. Felipe ContrerasMay 7, 2012
  12. Junio C HamanoMay 7, 2012
  13. Felipe ContrerasMay 7, 2012
  14. Junio C HamanoMay 7, 2012
  15. Felipe ContrerasMay 8, 2012
  16. 6/6 completion: add public _GIT_complete helperFelipe Contreras, May 7, 2012
  17. Junio C HamanoMay 7, 2012
  18. Felipe ContrerasMay 7, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.