From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Mon, 07 May 2012 21:01:12 GMT
Subject: Re: [RFC/PATCH v4 5/6] completion: calculate argument position properly
Message-ID: <CAMP44s3rC6bT3rjrBFdnywwsp5NrXt54L5L-7oKZ=bNFKccq+w@mail.gmail.com>
In-Reply-To: <7v7gwn6cmv.fsf@alter.siamese.dyndns.org>

On Mon, May 7, 2012 at 8:59 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Mon, May 7, 2012 at 3:23 AM, Felipe Contreras
>> <felipe.contreras@gmail.com> wrote:
>>
>>> @@ -2642,6 +2642,8 @@ _git ()
>>>                return
>>>        fi
>>>
>>> +       (( cmd_pos = c + 1 ))
>>
>> Actually, I would prefer cmd_pos=$((c + 1)).
>
> Yeah, that would feel more natural.
>
> Together with 4/6, I am guessing that you are using $cmd and $cmd_pos as a
> global variable to pass state to/from helper functions.  Are they properly
> documented in code (if not, please do so)?

Like cur, prev, words, and cwords? Wait a second... they are not
documented anywhere. I'm also not going to work on this... not my
itch.

-- 
Felipe Contreras