Re: ZSH segmentation fault while completing "git mv dir/"

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 1, 2013, 10:11 UTC
Message-ID: <CAMP44s3ocY7qpESHCDRdHJBsH1DV+k1Z5OwSqsWndMZd_s6oBQ@mail.gmail.com>
In-Reply-To: <vpqwqtdkq9z.fsf@grenoble-inp.fr>

On Tue, Mar 12, 2013 at 1:53 AM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 10 quoted lines

> If I add a simple 'echo "$cur" >&2' instead of the case, the problem
> reappears. Somehow, the fact that I'm accessing $cur seems to create the
> segfault. Actually, the minimalistic _git_mv reproducing the problem is:
>
> _git_mv ()
> {
>         echo "$cur"
>         [ $(__git_count_arguments "mv") = 1 ]
>         __git_complete_index_file "--cached --others --directory"
> }

I managed to reproduce the issue, and to me, this is enough:

_git_mv () { __gitcomp_file 'bar.txt' 'foo/' }

And this is a workaround:

--- a/contrib/completion/git-completion.zsh
+++ b/contrib/completion/git-completion.zsh
@@ -66,7 +66,7 @@ __gitcomp_file ()

        local IFS=$'\n'
        compset -P '*[=:]'
-       compadd -Q -p "${2-}" -f -- ${=1} && _ret=0
+       compadd -Q -p "${2-}" -- ${=1} && _ret=0
 }

 _git ()

Cheers.

--
Felipe Contreras