Re: ZSH segmentation fault while completing "git mv dir/"

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 2, 2013, 16:48 UTC
Message-ID: <7va9pgg9p7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpqwqslgfzf.fsf@grenoble-inp.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Show 16 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> And this is a workaround:
>>
>> --- a/contrib/completion/git-completion.zsh
>> +++ b/contrib/completion/git-completion.zsh
>> @@ -66,7 +66,7 @@ __gitcomp_file ()
>>
>>         local IFS=$'\n'
>>         compset -P '*[=:]'
>> -       compadd -Q -p "${2-}" -f -- ${=1} && _ret=0
>> +       compadd -Q -p "${2-}" -- ${=1} && _ret=0
>>  }
>
> OK, not something we want to apply to git.git, but this means a
> workaround for users is to ...

Would it help users more to have that as part of the instruction at the beginning of contrib/completion/git-completion.zsh where it already says "here is how you use it via fpath", than leaving it here in the list archive?

> (Hope this helps in case someone has the same problem and finds this
> thread ...)