Re: [PATCH] git-remote-testgit: avoid process substitution

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 26, 2013, 22:45 UTC
Message-ID: <CAMP44s3j5Bk3eqPeN2qkGTWFLO2NKz0taTGYVNvEut_VM=0NXA@mail.gmail.com>
In-Reply-To: <7vobd1udz2.fsf@alter.siamese.dyndns.org>

On Fri, Apr 26, 2013 at 5:25 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 19 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Thu, Apr 25, 2013 at 12:56 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:
>>> From: Johannes Sixt <j6t@kdbg.org>
>>>
>>> Bash on Windows does not implement process substitution.
>>
>> Nevermind, reporting all the refs creates a lot of irrelevant output,
>> this version is fine.
>
> When $before has this in it:
>
>         refs/heads/refs/heads/master 664059...126eaa7
>
> and your "read ref a" got this in the input:
>
>         refs/heads/master 664059...126eaa7
>
> would the pattern matching by case work corretly?

No, it wouldn't, but I don't think there's any way to do \<\> or \b in globs.

Alternatively, we could use the same $before and $after, and simply store the output somewhere; $GIT_DIR/testgit-before, for example. This should decrease the amount of changes needed, but I don't know if anybody would have problems with the use of 'join'.

Cheers.

-- 
Felipe Contreras