Re: [PATCH] git-remote-testgit: avoid process substitution
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 25, 2013, 18:25 UTC
- Message-ID
- <7vwqrq31tv.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CAMP44s0FHnm0xeSuzVNxVhn_rMQ=oKqoDxCU+OWGKPNOxmnGyA@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 14 quoted lines
>>> ... >>> + git for-each-ref --format='%(refname) %(objectname)' | >>> + while read ref a >>> do >>> - test $a == $b && continue >>> + case "$before" in >>> + *"$ref $a"*) >>> + continue >> > I wonder if we should bother with this at all. The purpose of the code > was mainly to show to users that they should report the success only > if the refs have been updated, but the code is becoming more > obfuscated, a comment should do the trick. And then, we can just > report success for all the refs (and explain in the comment why).
Are you proposing to say "ok $ref" to everything we see in the resulting repository, even the ones the caller of remote-testgit did not ask us to do anything with?
Wouldn't the caller be surprised if we did so?