Re: [PATCH] completion: add new zsh completion

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jan 30, 2012, 10:59 UTC
Message-ID: <CAMP44s3QeZuXrR=UE4qvDadu66Cmi-txmSps8Ow24om27URxOg@mail.gmail.com>
In-Reply-To: <vpqwr89d1p7.fsf@bauges.imag.fr>

On Mon, Jan 30, 2012 at 10:39 AM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 11 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> +ZSH_VERSION='' . /usr/share/git/completion/git-completion.bash
>
> Probably stating the obvious, but this path shouldn't be hardcoded.
>
> Something along the lines of
>
> ZSH_VERSION='' . $(dirname ${funcsourcetrace[1]%:*})/git-completion.bash
>
> should do it (mostly untested, and written by a non-ZSH expert).

Yes, it's hard-coded, because there's no way to know where is this file. In my case, it's on ~/.git-completion.sh, and this one that I am proposing sits in ~/.zsh/completion/_zsh, so your proposal breaks things completely for me.

I will think about it, but I think for now, users of this script should set that manually--if for some reason they don't want to use the default.

Maybe we should use zstyle so they can configure it on their .zshrc?

-- 
Felipe Contreras