Re: [PATCH] completion: add new zsh completion

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jan 30, 2012, 11:32 UTC
Message-ID: <CAMP44s2B_WLmGryUv9Fitak67nWhp8Gpw3Ac-dApKB4KjYv1fQ@mail.gmail.com>
In-Reply-To: <4F267AC9.1080407@viscovery.net>

On Mon, Jan 30, 2012 at 1:11 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:

Show 16 quoted lines

> Am 1/30/2012 9:39, schrieb Matthieu Moy:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> +ZSH_VERSION='' . /usr/share/git/completion/git-completion.bash
>>
>> Probably stating the obvious, but this path shouldn't be hardcoded.
>>
>> Something along the lines of
>>
>> ZSH_VERSION='' . $(dirname ${funcsourcetrace[1]%:*})/git-completion.bash
>>
>> should do it (mostly untested, and written by a non-ZSH expert).
>
> Moreover, if zsh is POSIX compliant, the value of ZSH_VERSION will be an
> empty string after this statement. That may or (more likely) may not be
> what you want.

It's not, only inside that script. Same in bash.

And that's exactly what I want... I wan the git-completion.bash to avoid any zsh hacks and workarounds.

Cheers.

-- 
Felipe Contreras