git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] transport-helper: call git fast-import properly

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Oct 18, 2012, 07:39 UTC
Message-ID
<CAMP44s3FsdF7944TkO3CVCV9d80TTocE5zXyE8sh1bXL0eMu5Q@mail.gmail.com>
In-Reply-To
<CAGdFq_jNs_CNN8PGbbgvJbmNTSSN9TaEDxCSyDEpScZL4zyiwg@mail.gmail.com>
On Thu, Oct 18, 2012 at 7:13 AM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
Show 7 quoted lines
> On Wed, Oct 17, 2012 at 1:27 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> The marks options are being ignored right now.
>
> It seems unlikely to me that this never worked, surely no reviewer
> would accept a patch that doesn't actually implement the feature?
> What's the history here?

Now I see, the {import,export}-marks options are only meant for fast-export, for fast-import one should use the 'feature' commands. It took me a while because the git_remote_helper code for python is very confusing: it uses testgit.marks for the marks that git generates, and git.marks for the marks that testgit generates.

It's not very convenient for remote-helpers that can export single branches as opposed to the whole repo:

http://github.com/felipec/git/commit/0961fdf8231a4ac057eec8a306a708e66f7b6ae9
But it works, so this patch is not needed.
-- 
Felipe Contreras
Previous: Sverre Rabbelier
Message 3 of 3 in “transport-helper: call git fast-import properly”
  1. transport-helper: call git fast-import properlyFelipe Contreras, Oct 17, 2012
  2. Sverre RabbelierOct 18, 2012
  3. Felipe ContrerasOct 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.