From: Felipe Contreras Date: Thu, 18 Oct 2012 07:39:35 GMT Subject: Re: [PATCH] transport-helper: call git fast-import properly Message-ID: In-Reply-To: On Thu, Oct 18, 2012 at 7:13 AM, Sverre Rabbelier wrote: > On Wed, Oct 17, 2012 at 1:27 AM, Felipe Contreras > wrote: >> The marks options are being ignored right now. > > It seems unlikely to me that this never worked, surely no reviewer > would accept a patch that doesn't actually implement the feature? > What's the history here? Now I see, the {import,export}-marks options are only meant for fast-export, for fast-import one should use the 'feature' commands. It took me a while because the git_remote_helper code for python is very confusing: it uses testgit.marks for the marks that git generates, and git.marks for the marks that testgit generates. It's not very convenient for remote-helpers that can export single branches as opposed to the whole repo: http://github.com/felipec/git/commit/0961fdf8231a4ac057eec8a306a708e66f7b6ae9 But it works, so this patch is not needed. -- Felipe Contreras