git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 02/12] completion: simplify __gitcomp

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 8, 2012, 14:11 UTC
Message-ID
<CAMP44s2vdEzn8_N=sauq-6OvqA+4tDtM9+yYYWuiQHgkZ2DyYA@mail.gmail.com>
In-Reply-To
<20120408132704.GB4103@burratino>
Hi,

I've looked at the history of __gitcomp and __gitcomp_nl, now I think it makes sense to keep their arguments similar, at least for the time being.

So I suggest this patch to be dropped.
On Sun, Apr 8, 2012 at 4:27 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 21 quoted lines
> Felipe Contreras wrote:
>
>> So we should never make any cleanups because some custom completion
>> functions might theoretically break?
>
> No, tasteful cleanups that don't break custom completion functions are
> very welcome.
>
> Also if you have evidence that this is definitely (not just possibly)
> only a theoretical problem, then it would not be a regression.  But I
> actually find it likely that custom completion code would have
> imitated the old completion code in git that used the suffix argument,
> so...
>
> Can you remind me what the benefit that the user is getting from this
> patch in exchange for us breaking their tab completion?  The title
> ("simplify __gitcomp") tells me exactly nothing about its impact
> except that it is perhaps supposed to result in no behavior change.
>
> Sorry for the fuss and hope that helps,
> Jonathan
Previous: Felipe ContrerasNext: Jonathan Nieder
Message 26 of 48 in “Bash completion rework”
  1. 00/12 Bash completion reworkFelipe Contreras, Apr 8, 2012
  2. 01/12 tests: add initial bash completion testsFelipe Contreras, Apr 8, 2012
  3. Junio C HamanoApr 8, 2012
  4. Jeff KingApr 8, 2012
  5. Junio C HamanoApr 8, 2012
  6. Jeff KingApr 8, 2012
  7. Jeff KingApr 8, 2012
  8. Andreas SchwabApr 8, 2012
  9. Jeff KingApr 8, 2012
  10. Felipe ContrerasApr 11, 2012
  11. Junio C HamanoApr 11, 2012
  12. Jeff KingApr 8, 2012
  13. Jonathan NiederApr 8, 2012
  14. Jeff KingApr 8, 2012
  15. Junio C HamanoApr 9, 2012
  16. John KeepingApr 8, 2012
  17. 02/12 completion: simplify __gitcompFelipe Contreras, Apr 8, 2012
  18. SZEDER GáborApr 8, 2012
  19. Felipe ContrerasApr 8, 2012
  20. Jonathan NiederApr 8, 2012
  21. Felipe ContrerasApr 8, 2012
  22. Jonathan NiederApr 8, 2012
  23. Felipe ContrerasApr 8, 2012
  24. Johannes SixtApr 9, 2012
  25. Felipe ContrerasApr 9, 2012
  26. Felipe ContrerasApr 8, 2012
  27. Jonathan NiederApr 8, 2012
  28. Junio C HamanoApr 9, 2012
  29. 03/12 completion: simplify __gitcomp_1Felipe Contreras, Apr 8, 2012
  30. 04/12 completion: trivial simplificationFelipe Contreras, Apr 8, 2012
  31. 05/12 completion: add missing global optionsFelipe Contreras, Apr 8, 2012
  32. John KeepingApr 8, 2012
  33. SZEDER GáborApr 8, 2012
  34. 06/12 tests: add more bash completion testsFelipe Contreras, Apr 8, 2012
  35. 07/12 completion: simplify command stuffFelipe Contreras, Apr 8, 2012
  36. SZEDER GáborApr 11, 2012
  37. Felipe ContrerasApr 11, 2012
  38. SZEDER GáborApr 11, 2012
  39. Felipe ContrerasApr 11, 2012
  40. Felipe ContrerasApr 12, 2012
  41. 08/12 completion: simplify _git_bundleFelipe Contreras, Apr 8, 2012
  42. 09/12 completion: calculate argument position properlyFelipe Contreras, Apr 8, 2012
  43. 10/12 completion: add new git_complete helperFelipe Contreras, Apr 8, 2012
  44. SZEDER GáborApr 11, 2012
  45. Felipe ContrerasApr 11, 2012
  46. 11/12 test: add tests for aliases in bash completionFelipe Contreras, Apr 8, 2012
  47. Felipe ContrerasApr 8, 2012
  48. 12/12 completion: rename _git and _gitkFelipe Contreras, Apr 8, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.