Re: [PATCH] remote-helpers: remove --graph in hg_log()

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 6, 2013, 16:06 UTC
Message-ID: <CAMP44s2tdKhGuH3E7nGqU4R3jgEw4tH-=Cq6dhHwiLc=b_fm6Q@mail.gmail.com>
In-Reply-To: <1365264055-30507-1-git-send-email-apelisse@gmail.com>

On Sat, Apr 6, 2013 at 10:00 AM, Antoine Pelisse <apelisse@gmail.com> wrote:

> The hg_log() test helper uses the "--graph" parameter that is
> implemented by the GraphLog extension. If the extension is not activated
> by the user, the parameter is not available. Do not use the option that
> is unnecessary.

> I'm not so confident that --graph is useless to the test. If it's really
> necessary, it would be nice either to activate it in setup() or to use
> it just for the command through: "--config extensions.graphlog=".

I think it should be activated in the setup, it comes packaged with mercurial, and it's likely that many users have it enabled.

> Also changes the way we grep the output in hg_log(). The pipe operator
> can hide the return code of hg command. As a matter of fact, if log
> fails because it doesn't know about "--graph", it doesn't report any
> failure and let's you think everything worked.

Yeap, that is good to have.

Cheers.

-- 
Felipe Contreras