Re: [PATCH] remote-helpers: remove --graph in hg_log()
- From
Antoine Pelisse <apelisse@gmail.com>
- Date
- Apr 6, 2013, 16:12 UTC
- Message-ID
- <CALWbr2yhZW46RB=8gUivcN4r5NFhk0y-0ND-X2c8ALKos6qi=Q@mail.gmail.com>
- In-Reply-To
- <CAMP44s2tdKhGuH3E7nGqU4R3jgEw4tH-=Cq6dhHwiLc=b_fm6Q@mail.gmail.com>
On Sat, Apr 6, 2013 at 6:06 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:
Show 7 quoted lines
> On Sat, Apr 6, 2013 at 10:00 AM, Antoine Pelisse <apelisse@gmail.com> wrote: >> I'm not so confident that --graph is useless to the test. If it's really >> necessary, it would be nice either to activate it in setup() or to use >> it just for the command through: "--config extensions.graphlog=". > > I think it should be activated in the setup, it comes packaged with > mercurial, and it's likely that many users have it enabled.
But is it relevant to the tests ? I have the feeling that it's not strictly necessary to both add an extension to hgrc and a command line option. (and indeed, the tests still work for me, but maybe I'm missing something).