Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Oct 30, 2012, 22:56 UTC
- Message-ID
- <CAMP44s2fgB=ruuVBdG6QjF6yviQAxVWFyhN6Vh3DWMGgmOKzyQ@mail.gmail.com>
- In-Reply-To
- <CAGdFq_iiGpYW-txPaa6mZrxg3mYdOX-Ez9uLF-rB5bAjZd5rWg@mail.gmail.com>
On Tue, Oct 30, 2012 at 11:35 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
Show 6 quoted lines
> On Tue, Oct 30, 2012 at 3:18 PM, Felipe Contreras > <felipe.contreras@gmail.com> wrote: >> Which is expected and correct; the branch already points to the right >> commit, no need for an extra reset. > > I think you're correct. Thanks for confirming.
Thanks for reviewing. If you are still not convinced, I could pull the patches from msysgit and simplify them, I'm sure the end result would be pretty similar, if not exactly the same as this patch (plus other orthogonal changes). I saw some patches that were not part of the patch series you sent before, so maybe that's why you expected certain behavior that wasn't actually there in that particular patch series.
But hopefully that's not needed.
Cheers.
-- Felipe Contreras