Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Nov 11, 2012, 17:49 UTC
- Message-ID
- <CAMP44s2ec-m0Jta2bQeg2McKAFCR6MSSP4nQx3-T=2W=3xUeyw@mail.gmail.com>
- In-Reply-To
- <509FE2EA.3020407@gmail.com>
On Sun, Nov 11, 2012 at 6:39 PM, A Large Angry SCM <gitzilla@gmail.com> wrote:
> On 11/11/2012 12:16 PM, Felipe Contreras wrote:
Show 7 quoted lines
>> And how do you propose to find the commit commands without parsing all >> the other commands? If you randomly look for lines that begin with >> 'commit /refs' you might end up in the middle of a commit message or >> the contents of a file. > > I didn't say you didn't have to parse the protocol. I said that the protocol > is pretty simple.
Parsing is never simple.
Show 9 quoted lines
>>> I agree that an additional filter _may_ decrease performance somewhat if >>> you >>> are already CPU constrained. But I suspect that the effect would be >>> negligible compared to the all of the SHA-1 calculations. >> >> Well. If it's so easy surely you can write one quickly, and I can measure >> it. > > Not my itch; You care, you do it.
It was your idea, I don't care.
If it's so simple, why don't you do it? Because it's not that simple. And anyway it will have a performance penalty.
-- Felipe Contreras